Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Guacamole's authentication URI to support auto update in workspace app #2118

Merged
merged 5 commits into from
Jun 26, 2022

Conversation

tamirkamara
Copy link
Collaborator

Fixes #2109

What is being addressed

The returned connection uri output from the Guacamole bundle isn't the one AAD redirects the user to after authentication which is causing a failure in the flow.

How is this addressed

  • Add a new output for the uri used in the authentication redirect
  • Use the uri in the bundle's pipeline definition so that it could be correctly updated in the workspace app
  • Reference the providers.tf file for better caching in porter

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2563149543 (with refid 859a1fe9)

(in response to this comment from @tamirkamara)

Base automatically changed from tamirkamara/2085-workspace-app-service-sku-param to main June 26, 2022 08:35
@github-actions
Copy link

github-actions bot commented Jun 26, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit fbc6bd6.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara marked this pull request as ready for review June 26, 2022 08:40
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2563666156 (with refid 859a1fe9)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 5d7db1c into main Jun 26, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2109-guacamole-authn-uri branch June 26, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guacamole's connection_uri output isn't enough for automated e2e provisioning
2 participants